[release-1.3] 🐛 test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster #8315
Conversation
cluster Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/test pull-cluster-api-e2e-full-release-1-3 |
|
/assign @fabriziopandini @killianmuldoon |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 47bfd337d0b86423213f420202b11c2bc9753117
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@furkatgofurov7 @killianmuldoon @ykakarap @fabriziopandini This broke e2e-mink8s on release-1.3 as it has ClusterTopology disabled. I would propose to use Kubernetes 1.22 for the e2e-mink8s test so we can enable ClusterTopology: https://github.com/kubernetes/test-infra/pull/29094/files I think this is simpler then trying to do bigger changes on the release-1.3 branch to use the right cgroupDriver without ClusterClass. I think as we already have a few 1.3 patch releases out we can remain confident regardless that 1.3 works with Kubernetes 1.20 management clusters |
|
Btw for this case #8224 would have helped. But as of today it's not possible to run e2e-mink8s on PRs. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Cherry-pick of #8311
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #